search

ac3cloud / roust

Ruby client for Request Tracker's REST API
Other
6 stars 4 forks source link

Refactor specs, use shared contexts #4

Closed auxesis closed 10 years ago

auxesis commented 10 years ago

@rimian would appreciate any feedback you have on the test structure.

rimian commented 10 years ago

No worries. Have you run rubocop on it?

auxesis commented 10 years ago

Have you run rubocop on it?

Nope! I'll set that up.

rimian commented 10 years ago

@auxesis see flak or kevlar. I reckon we need a todo and a project yaml for rubocop.

rimian commented 10 years ago

Looks good. I would fix the foo.should be into expect(foo).to be and that would be enough to merge. Also recommend running rspec 2.99 on it and see if it gives you any useful feedback. :+1:

auxesis commented 10 years ago

@rimian awesome, thanks for the feedback.

TODO: