search

aca / go-kubectx

5x-10x faster alternative to kubectx. Uses client-go.
134 stars 3 forks source link

fzf should be optional #10

Open zbbfufu opened 4 years ago

zbbfufu commented 4 years ago

In original kubectx/kubens, fzf is optional and fuzzy searching features only activates if fzf is found on the path. Having the same behavior in go-kubectx will ease switching to your implementation.

aca commented 4 years ago

@zbbfufu That's fair points. Will try with some other libraries later.

caarlos0 commented 4 years ago

could actually probably import fzf as a lib as well 🤔

zbbfufu commented 4 years ago

I was more thinking about a feature switch based on fzf availability, but including fzf in binary may be an option :)

Le lun. 2 mars 2020 à 19:59, Carlos Alexandro Becker < notifications@github.com> a écrit :

could actually probably import fzf as a lib as well 🤔

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aca/go-kubectx/issues/10?email_source=notifications&email_token=AACRQ7VD4ZOZMDZ6SBCIZ7DRFP625A5CNFSM4K7RX7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENQQUMQ#issuecomment-593562162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRQ7XBTEVXOQP3NWSVLBTRFP625ANCNFSM4K7RX7LA .