I created a virtual machine with Ubuntu 16.04 using vagrant and created an user with the home folder /home/cleber alcantara/.
I installed composer, laravel and adminlte-installer.
I created a laravel project and tried to run adminlte-laravel install. This last command generated the errors described in the issue mentioned in the previous section.
I edited the files in the /home/cleber alcantara/.composer/vendor/acacha/adminlte-laravel-installer and /home/cleber alcantara/.composer/vendor/acacha/llum in order to fix the problems.
I created a project using laravel and ran adminlte-laravel install successfully.
I tested the new projects in my browser and they worked as expected.
I renamed home directory to /home/cleber and proceeded the same way, creating projects using laravel and running adminlte-laravel install. No errors occurred, which means my changes did not affect the "normal cases" when the paths for llum and adminlte-laravel do not have spaces.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Description
I made llum able to deal with paths that contain spaces. My changes can be summarized as bellow:
passthru
in some PHP files for the paths; andMotivation and context
Users that have llum installed in a folder that has a space in the full path could not run llum because it was generating errors as the path is "broken" because of the space. This issue was opened at https://github.com/acacha/adminlte-laravel/issues/225. A pull request for AdminLTE Laravel Installer is proposed as part of the solution for the problem: https://github.com/acacha/adminlte-laravel-installer/pull/13.
How has this been tested?
This is what I did:
/home/cleber alcantara/
.adminlte-laravel install
. This last command generated the errors described in the issue mentioned in the previous section./home/cleber alcantara/.composer/vendor/acacha/adminlte-laravel-installer
and/home/cleber alcantara/.composer/vendor/acacha/llum
in order to fix the problems.adminlte-laravel install
successfully./home/cleber
and proceeded the same way, creating projects using laravel and runningadminlte-laravel install
. No errors occurred, which means my changes did not affect the "normal cases" when the paths for llum and adminlte-laravel do not have spaces.Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply: