search

academe / OmniPay-Payone

A PAYONE gateway driver for the OmniPay framework
MIT License
15 stars 16 forks source link

Refactor message inheritance #10

Closed judgej closed 7 years ago

judgej commented 8 years ago

There are methods and data relevant only to Server, Front End or Client API types, but are all lumped into the shared abstract request. Another layer for each of the three API types would keep those methods and data closer to where they are relevant and not leak to the other API types.

This is not absolutely necessary, but would be neater and would make testing easier.

judgej commented 7 years ago

We'll leave this for now. It was a nice-to-have while in development.