search

academe / OmniPay-Payone

A PAYONE gateway driver for the OmniPay framework
MIT License
15 stars 16 forks source link

More options for payment methods(sepa, sofort) and invoicing for authorize requests #19

Closed mcbuckets closed 7 years ago

judgej commented 7 years ago

Since the ShopServerCaptureRequest extends the ShopServerAuthorizeRequest, and the ShopServerCaptureRequest already has many of these new setters and getters, is it worth removing them from ShopServerCaptureRequest where they are effectively redundant? i.e. ultimately shifting them up a level in the hierarchy?

mcbuckets commented 7 years ago

Of course, i updated the PR. In the long run i think it would be great to move them up