search

academe / OmniPay-Payone

A PAYONE gateway driver for the OmniPay framework
MIT License
15 stars 16 forks source link

Dennis dittmann patch 2 #23

Closed DennisDittmann closed 7 years ago

DennisDittmann commented 7 years ago

added getter and setter for wallettype

if parameter 'clearingtype' equals 'wlt' (e-wallet), the wallettype (PayPal, Paydirekt, ...) must be transfered to PAYONE, too

judgej commented 7 years ago

Couple of questions:

I've not tried this myself yet. It would be nice to get it in a release.

judgej commented 7 years ago

For the front end API, the wallet type seems to be ignored - you can add anything you like to it without error. This probably explains why it it not in the hash, because it is not used, at least not when the user is presented with the payment form (e.g. in an iframe).

However, things may be a little different when autosubmit is turned on.

Edit: just tried it, with some [committted] additional support for autosubmit. On autosubmit, if the wallettype is recognised - i.e. just PPE at this time - then the user is taken direct to PayPal Express. If the wallettype is not recognised, then the user is left with the PAYONE form to choose the required wallet merchant (which is just PayPal Express).

The wallettype was not implemented in the Frontend API, which it now is, but I have added it as an optional setting and not into the getBaseData() method as for this PR. Hopefully that will work for you; let me know how it goes on teh master-dev branch if you can. Thanks.

DennisDittmann commented 7 years ago

Hello!

Sorry for the late answer!

The wallet type parameter is used / was needed in the following situation:

In our online shop we offer payment via PayPal and Paydirekt, for example. (Both are e-wallet payment methods.)

The user clicks on "Payment via Paydirekt", for example.

Then a Payone GUI is opened where the user can enter something, among other things radio buttons to choose between PayPal and Paydirekt payment method are displayed in this GUI.

But now the PayPal payment method is preselected instead of the Paydirekt payment method. (!) This led to some trouble when user bought something in the shop.

Therefore we had to transfer the wallet type to Payone, too.

Unfortunately, I cannot say more. It worked this way and led to no other errors. And then we did not inspect this topic no more. I think you are the expert and can understand this topic much better. I just can point to the Payone api we tried to use: https://www.payone.com/fileadmin/downloads/sonstiges/PAYONE_Platform_Frontend_EN.pdf .

And many thanks for your library. It was extremely useful. Have a nice weekend!

Kind regards, Dennis Dittmann

2017-05-21 13:40 GMT+02:00 Jason Judge notifications@github.com:

For the front end API, the wallet type seems to be ignored - you can add anything you like to it without error. This probably explains why it it not in the hash, because it is not used, at least not when the user is presented with the payment form (e.g. in an iframe).

However, things may be a little different when autosubmit is turned on.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/academe/OmniPay-Payone/pull/23#issuecomment-302931397, or mute the thread https://github.com/notifications/unsubscribe-auth/AbH-2KFVHsoi9z90DxZNfvuxF8GQkBmSks5r8CKkgaJpZM4NZRsm .

-- KM2 >> netz:innovationen.gmbh kai unterberg, geschäftsführung fürstenwall 141, 40215 düsseldorf fernruf: 0 211 / 175 419 30 fernkopie: 0 211 / 175 419 59 web: www.km2.de registergericht: ag düsseldorf, hrb 39505 ust.-id: DE 215640514, sitz: düsseldorf geschäftsführer: kai unterberg