academe / OmniPay-Payone

A PAYONE gateway driver for the OmniPay framework
MIT License
15 stars 16 forks source link

Standardise card token/pseudo pan/cardReference #7

Open judgej opened 8 years ago

judgej commented 8 years ago

Some discussion for OmniPay 3.0 here:

https://github.com/thephpleague/omnipay/issues/387

If a standard/convention for card tokens is developed for 3.0, then it would be great to backport it here. If we standardize on naming the token cardReference for example, then methods such as getToken() would need to be changed or aliased.

Similarly, passing the token into messages such as ShopServerAuthorizeRequest should use the agreed method and maybe not piggy-backing on the creditCard object.