search

academe / SagePay-Integration

HTTP Messages for the Sage Pay REST (Pi) gateway.
GNU General Public License v3.0
9 stars 5 forks source link

Test UTF-8, more #14

Closed judgej closed 8 years ago

judgej commented 8 years ago

Sending UTF-8 extended characters, they appear in the testing panel as question marks (?). It is not clear where that conversion is taking place - at the gateway, or within the Guzzle client.

The gateway test panel is a shameless ISO8859-1, but UTF-8 encoded characters that fit into the extended ASCII set are being correctly converted somewhere. So Iñtërnâtiônàlizætiøn as UTF-8 is displaying as Iñtërnâtiônàlizætiøn in the testing panel. But ｱｲｳｴｵｶｷｸｹｺｻｼｽｾｿﾀﾁﾂﾃ goes over as ???????????????????. The character counts are correct, so something is making a good attempt at converting the UTF encoding, but is using "?" as the out-of-bounds replacement character.

judgej commented 8 years ago

Let's just merge this into Issue #15 (Create some tests). Tests can be written for character encoding edge-cases.