Move 3DSecure reponse to a payment to a message class of its own

academe / SagePay-Integration

HTTP Messages for the Sage Pay REST (Pi) gateway.

GNU General Public License v3.0

9 stars 5 forks source link

Move 3DSecure reponse to a payment to a message class of its own #37

Closed judgej closed 8 years ago

judgej commented 8 years ago

Currently this is built into Response\Payment as it was inherited from Response\Transaction. It is different enough from a Payment message to be a message of its own, simplifying Payment in the process.

judgej commented 8 years ago

Classes to be:

Request\Secure3D - send the paRes to Sage Pay after the user returns from the bank.
Response\Secure3D - the 3D Secure status (can be embedded into Payment)
Response\Secure3DRedirect - a redirect is required to the bank to complete 3D Secure

Key here is that the Response\Payment class can no longer handle a 3D Secure redirect, which must be passed to the Response\Secure3DRedirect message now. A check with an exception will be put in place as a safety measure.

judgej commented 8 years ago

Done.