academe / SagePay-Integration

HTTP Messages for the Sage Pay REST (Pi) gateway.
GNU General Public License v3.0
9 stars 5 forks source link

3D Secure object structure fix #43

Closed judgej closed 7 years ago

judgej commented 7 years ago

An earlier version of the spec listed the 3D Secure status response wrapped in a 3DSecure element. This does not happen in the final 3D Secure status response, which now looks like this:

{
    "status" : "Authenticated"
}

The documentation was recently changed to correct this (though did not get a changelog entry).

This kind makes recognising objects a little more difficult, because "status" on its own has absolutely no context. Will need to look at whether any of the request details can be used as a part of the context when converting a PSR-7 response message into the appropriate class.

judgej commented 7 years ago

Done as a part of issue #45