search

academe / SagePay-Integration

HTTP Messages for the Sage Pay REST (Pi) gateway.
GNU General Public License v3.0
9 stars 5 forks source link

RepeatPayment supports giftAid option #50

Closed judgej closed 7 years ago

judgej commented 7 years ago

Repeat payments originally did not support any option flags. It not appears to support giftAid, so add that one at least.

judgej commented 7 years ago

These flags default to false in the API if not set. This package will set it to true if required, or leave it blank (so it defaults to false if not. It may make more sense for the flag to be tri-state: true, false or null, so a false can be enforced if required, even if just for testing or providing a clearer data audit trail.

For now, the approach works, so we'll leave it is it is, but will keep it mind.