search

academe / SerializeParser

A PHP parser for serialized data, to be able to "peek" into serialize strings.
MIT License
4 stars 2 forks source link

Unit tests #7

Open jj5 opened 7 years ago

jj5 commented 7 years ago

Hello Pierre. I'm new to GitHub and still learning the processes. I thought I'd start with a simple pull request. This one only has two files for one unit test. The unit test shows that there is a problem with unicode support. I can fix this, but I'll do that later.

judgej commented 7 years ago

Thanks, I'm going to have a go at merging these tests into the "tests" directory. I'm aiming to use an autoloader for testing, defaulting to the composer autoloader if it is available.

jj5 commented 7 years ago

Hi there.

I haven't used this GitHub email service before... I hope someone gets this message.

I have sync'ed my fork and got the new unit tests in the ./tests directory, but I don't know how to run them...

How do I run the unit tests? Thanks for being patient with me, I'm new.

Cheers, John Elliot V

On 27/02/17 11:24, Jason Judge wrote:

Thanks, I'm going to have a go at merging these tests into the "tests" directory. I'm aiming to use an autoloader for testing, defaulting to the composer autoloader if it is available.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/academe/SerializeParser/pull/7#issuecomment-282601768, or mute the thread https://github.com/notifications/unsubscribe-auth/AFNzbwsqIQCtzUYnWTpsPIZh2mG3RZseks5rghfagaJpZM4MMgSw.

-- ProgClub: because every programmer needs a good club! https://www.progclub.org/

John Elliot V is creating Free Software and Open Communities: https://www.patreon.com/jj5

jj5 commented 7 years ago

I figured out how to run the unit tests... first:

composer install

Then:

phpunit

Will add some tests and submit a new PR... stay tuned.

On 27/02/17 11:24, Jason Judge wrote:

Thanks, I'm going to have a go at merging these tests into the "tests" directory. I'm aiming to use an autoloader for testing, defaulting to the composer autoloader if it is available.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/academe/SerializeParser/pull/7#issuecomment-282601768, or mute the thread https://github.com/notifications/unsubscribe-auth/AFNzbwsqIQCtzUYnWTpsPIZh2mG3RZseks5rghfagaJpZM4MMgSw.

-- ProgClub: because every programmer needs a good club! https://www.progclub.org/

John Elliot V is creating Free Software and Open Communities: https://www.patreon.com/jj5