search

academe / laravel-azure-file-storage-driver

Azure File Storage filesystem driver for Laravel
MIT License
16 stars 1 forks source link

driverOptions is actually passed to the Azure driver as the prefix #3

Open judgej opened 4 years ago

judgej commented 4 years ago

Some parameter misalignment here, and I've only just noticed because I am setting a root directory for a file share for the first time.

So what works now in config:

'driverOptions' => 'root-directory',

What should be implemented:

'root' => 'root-directory',

The driverOptions were supposed to be passed directly to the Azure driver. Looking at how that works, I think the driverOptions can probably be merged into the main config array used to instantiate the AzureFileAdapter.

To help prevent breakage, if driverOptions is set to a non-empty string, I will use that in place of root. If root is set, since that is new, that will take precedence.

judgej commented 4 years ago

I'll make a quick release with support for the new 'root' option, but some additional work is needed to look at what kind of options need to be passed into the Azure driver, and how they will get passed.