search

academia-de-codigo / react-semantic-toasts

React Semantic UI notifications library
MIT License
87 stars 31 forks source link

Passing props #45

Closed jankaifer closed 5 years ago

jankaifer commented 5 years ago

Fixed issues with MR #42.

fixes #40

jankaifer commented 5 years ago

I also thought about removing all props that are not modified ie. onClick.

ferrao commented 5 years ago

@JanKaifer Yes, I think you should remove all props that are not modified or handled specifically in the SemanticToast component and just pass them down to the Message component and let it handle them.

There is also some conflicts between this branch and master branch, can you please solve those? Also your PR #46 seems to contain the same updates as this one.

jankaifer commented 5 years ago

Yay I forgot to push in #46. It should be ok now.

And I've also removed all those unmodified props.

jankaifer commented 5 years ago

I have also closed #46 because the issue #40 is fixed removing size prop altogether.

ferrao commented 5 years ago

Ok, looks good, will merge.