search

academic-innovation / frontend-component-footer-mogc

Custom MFE footer component for Global Classroom.
0 stars 0 forks source link

Cannot resolve dependencies when building Palm MFE container #11

Open michaelwheeler opened 2 weeks ago

michaelwheeler commented 2 weeks ago

The peer dependency specifier for frontend-platform in v14.3.0 is in conflict with frontend-app-gradebook (which is pinned at 2.5.0) and preventing builds of the mfe image in Palm.

https://github.com/academic-innovation/frontend-component-footer-mogc/blob/dbde2edcd81353137563c6ced3ed94bb86bd6cf4/package.json#L20

michaelwheeler commented 2 weeks ago

@aphilipharrell It seems like the specifier in v14.2.1 was less strict.

https://github.com/academic-innovation/frontend-component-footer-mogc/blob/5f2d630565aa4d03b85dd9686762c3c9264f4335/package.json#L20

Do you have any thoughts on switching back to that (or something similar)?

aphilipharrell commented 2 weeks ago

@michaelwheeler

Regarding it being less strict, I thought that meant 'anything greater than 1.8.0', but that didn't seem to be the case when I was working on the plugin upgrades as the container would fail on a different MFE each change that I made. I had succcessful builds of the MFE container on Palm with this new version setting, but maybe something with one of the other MFEs has changed in the interim?

I'm not an expert when it comes to dependency management nor do I know what best practice might be in a complex situation like this where the footer is used in different apps with different requirements, so am open to suggestions on how to proceed.

michaelwheeler commented 2 weeks ago

I'm not an expert when it comes to dependency management

Same. I had the same understanding of >1.8.0 that you did. Seems like this may require more thought.