search

academic-moodle-cooperation / moodle-mod_publication

Online texts and files can be collected and published via the Student Folder activity and thus made available to everyone in a Moodle course. Submissions can be made directly by uploading or alternatively can be taken over by teachers from an assignment activity.
https://academic-moodle-cooperation.org/mod_publication/
12 stars 21 forks source link

Notifications with wrong content and in wrong language #50

Closed cdipe closed 1 year ago

cdipe commented 3 years ago

Using Moodle 3.9.7 and Student Folder 3.9.0

Attached is a PDF with more details and screen shots.

Student Folder notifications problem report.pdf

tjettmers commented 3 years ago

@cdipe maybe identical with https://github.com/academic-moodle-cooperation/moodle-mod_publication/issues/41 ? should has been fixed with student folder 3.10

cdipe commented 3 years ago

@tjettmers it looks like it could be part of the problem. But there is also the mystery of the extra word in the text string ('approved') that is hard coded, but still don't show in the mail. And, the user's language preferences being ignored. This is a great plugin, the functionality has been long asked for by our teachers! I'm glad to hear there's a new version coming up, will it work with the 3.9 versions of Moodle?

goggo24 commented 3 years ago

I'm not sure if the language of the notification isn't trigged by the course language and not by the user's language preference - i will ask and come back to you.

As already mentioned above some of the errors have been already fixed with v.3.10.0 of the plugin - see https://github.com/academic-moodle-cooperation/moodle-mod_publication/issues/41. E.g. the hardcoded word - approved was not duplicated because the placeholder contained only the word not. Can you try it with a newer version?

Note: our Plugins only work with the corresponding Moodle Core Version. So v3.10 of publication under Moodle core 3.10 - if you want to use it, you have to change the required version in the version.php - however, we do not assume any guarantee, that it works under a minor versions, because we haven't tested it.

cdipe commented 3 years ago

@goggo24 ok thank you! (It would be great to have "back ported" to Moodle 3.9, since that is a LTS version that we and a lot of other users will have for a while.)

goggo24 commented 1 year ago

As 3.9 of Moodle Core is no longer supported for general bug fixes, we won't fix this bug. Please upgrade to a higher version - thanks.

cdipe commented 1 year ago

@goggo24 done, that was a while ago ;)