search

academic-moodle-cooperation / moodle-mod_publication

Online texts and files can be collected and published via the Student Folder activity and thus made available to everyone in a Moodle course. Submissions can be made directly by uploading or alternatively can be taken over by teachers from an assignment activity.
https://academic-moodle-cooperation.org/mod_publication/
12 stars 21 forks source link

Issues highlighted by admin/cli/check_database_schema.php #52

Closed abias closed 3 years ago

abias commented 3 years ago

Every now and then, we are running the admin/cli/check_database_schema.php script in our Moodle installation.

This time, these issues were highlighted:

-------------------------------------------------------------------------------
publication_groupapproval
 * column 'timecreated' should be NOT NULL (I)
 * column 'timecreated' has default 'NULL', expected '0' (I)
 * column 'timemodified' should be NOT NULL (I)
 * column 'timemodified' has default 'NULL', expected '0' (I)
-------------------------------------------------------------------------------

Upon investigation, I saw that there is a discrepancy between https://github.com/academic-moodle-cooperation/moodle-mod_publication/blob/master/db/upgrade.php#L101-L102 and https://github.com/academic-moodle-cooperation/moodle-mod_publication/blob/master/db/install.xml#L68-L83 which might have caused this issue.

May I ask you to have a look at these issues and fix them for existing installations by adding another step to upgrade.php?

Thanks in advance, Alex

goggo24 commented 3 years ago

Thanks for reporting. Fix will be included in v.3.11.1. of publication.

goggo24 commented 3 years ago

included in v.3.11.1