academic-moodle-cooperation / moodle-mod_publication

Online texts and files can be collected and published via the Student Folder activity and thus made available to everyone in a Moodle course. Submissions can be made directly by uploading or alternatively can be taken over by teachers from an assignment activity.
https://academic-moodle-cooperation.org/mod_publication/
12 stars 21 forks source link

"Nothing to display" shown without initials bar even though filtering by initials #74

Closed t-schroeder closed 11 months ago

t-schroeder commented 1 year ago

One of our students filtered the "All files" table by some firstname and lastname initial for which there is no student. That leads to the message "Nothing to display - no students available" to be shown. He then changed "Participants shown per page" to 100. Now the same message is shown but the initials bar is no longer visible because of https://github.com/academic-moodle-cooperation/moodle-mod_publication/blob/4955a5e9e896e36fc4944a87e3b6fe6d64e02958/classes/local/allfilestable/base.php#L269 There were only 22 students in that course.

The initials bar was no longer shown even though he was filtering by initials. That shouldn't happen. The workaround is either changing the "Participants shown per page" to some number that's lower than the number of submissions or clicking "Reset table preferences".

goggo24 commented 1 year ago

Thanks for reporting - we will have a look.

goggo24 commented 1 year ago

We were able to recreate the behavior and will fix it in the next version.

tsbartel commented 11 months ago

This behaviour unfortunately also applies across courses. (Sorry for creating a duplicate issue yesterday.)

If a student filters the list by initial in a course with lots of users but visits a mod_publication activity in another course:

goggo24 commented 11 months ago

The fix will be included in our next minor release - 4.2.2.

goggo24 commented 11 months ago

We have accepted the PR - the display of the initial bar is fixed now, but the filter still works cross-course. @tsbartel - we will add your comment to our backlog and will include it in our roadmap (probably in our next major version).