search

acadet / yimello

Browsing your bookmarks is not tricky anymore.
http://yimello.adriencadet.com/
MIT License
32 stars 3 forks source link

Re-import will duplicate old bookmarks #2

Closed pixelpicosean closed 9 years ago

pixelpicosean commented 10 years ago

Used the import from browser feature, and old bookmarks are duplicated. Bookmarks should be checked before been inserted.

acadet commented 10 years ago

Yeah I know, therefore importing from browser is a beta feature for the moment.

What behavior would you expect when importing? Just avoiding duplicates?

Also, you can add a new bookmark with the same URL. Unless URL are identical, it is hard to engine if target is the same. For instance, http://mysite.com and http://mysite.com?page=index target the same webpage but, currently, you can create two different bookmarks.

pixelpicosean commented 10 years ago

Well I dont think you should add same URL with different name which will be confusion. http://mysite.com is not same as http://mysite.com?page=index since the path is not the same. If anyone want to add the first, he/she will not add the second one if the pages looks the same. So I just want to avoiding complete duplicates - same name, same URL.

What do you think?

acadet commented 10 years ago

Alright, sounds great. I will introduce this feature for a futur update ;)

acadet commented 9 years ago

Ok, should be fixed in 0.3.0 version. Feel free to close issue if everything is alright from now on.