search

acadet / yimello

Browsing your bookmarks is not tricky anymore.
http://yimello.adriencadet.com/
MIT License
32 stars 3 forks source link

Error when attempting to import bookmarks from bookmarks file #5

Open ghost opened 9 years ago

ghost commented 9 years ago

Hello there.

Whenever attempting to drag an exported bookmarks file into the Yimello window (after choosing 'Import from browser' from the menu), I receive the following error message: Ow! Your URL is invalid. Please check it again. I would assume that this is associated in some way with the file:/// URL type not being parsed properly, and thus being regarded as an invalid URL.

If it is useful to you in any way, I am running Linux Mint 17 64-bit, with XFCE4 desktop (thus Thunar File Manager) and Mozilla Firefox for the exported bookmarks file.

Thank you!

acadet commented 9 years ago

Thanks for the feedback Aedx. Indeed, you are right, a URL starting with file:// would be parsed as wrong. I will fix that soon.

However, I am really surprised, why do you have internal bookmark?

ghost commented 9 years ago

What exactly do you mean by 'internal bookmark'? I simply exported my bookmarks from Firefox as an HTML file.

acadet commented 9 years ago

I thought you were meaning your tried to import a bookmark relative to a local address, starting with file://. The error message you got is coming from a URL validator, but it might be going wrong. It is not caused by your file. I will review it.

ghost commented 9 years ago

Ah - does that mean that bookmarklets beginning with javascript: and data: will also not work? I make great use out of non-HTTP protocols in my bookmarks, you might want to allow for them.