search

acadsamplesdb / acad_samples

ACAD samples database
0 stars 0 forks source link

Selecting samples on multiple pages does not work #28

Closed Li-ReDBox closed 8 years ago

Li-ReDBox commented 8 years ago

This was mentioned as a part of enhancement id 6: Make a project only works on one page. This needs to work when selecting on multiple page.

Li-ReDBox commented 8 years ago

@sgoodswen I have had a very rough set-up on the dev site only for selecting. You may be able to select samples on different pages. Partially worked for me. But still work to be done mainly when moving around, things might not correctly displayed and etc. On server side, nothing has been done yet: so you can not, for example, export samples on different pages, yet.

Also be aware of browser compatibility of old IEs.

I am not sure if I have understood the user cases, so there is no guarantee the implementation has met the requirement.

Li-ReDBox commented 8 years ago

The requirement changed to make a form with search ability for adding samples to a list for exporting or making a project.

Li-ReDBox commented 8 years ago

files to be changed to enable building a list on client side var search:

  1. https://github.com/acadsamplesdb/acad_samples/blob/master/samples/views.py#L874
  2. https://github.com/acadsamplesdb/acad_samples/blob/master/samples/templates/search/search.html
  3. https://github.com/acadsamplesdb/acad_samples/blob/master/acad_samples/urls.py#L102
  4. http://django-haystack.readthedocs.org/en/latest/searchresult_api.html#get-stored-fields
sgoodswen commented 8 years ago

The changes made to the Search menu to allow multiple samples to be selected is an acceptable solution. This issue can be closed once tested in production

Li-ReDBox commented 8 years ago

@sgoodswen do you want keep the issue open but deployed to production server?

sgoodswen commented 8 years ago

I would like to keep all the issues that you have fixed and deployed to production 'open' please, and then I will close them once I have tested them in production ... thanks

Li-ReDBox commented 8 years ago

@sgoodswen no problems. I have put close command into commits in other fixes as I always do because I was not aware this is a requirement. I will leave them as they are. If you find some issues were closed by commits, feel free to reopen them.

sgoodswen commented 8 years ago

The solution has been implemented correctly in production