search

acadsamplesdb / acad_samples

ACAD samples database
0 stars 0 forks source link

Carbon dates decimals issue in samples #45

Closed jsoubrier closed 8 years ago

jsoubrier commented 8 years ago

In https://samples.oagr.org.au/c14/, the values look good (only a few decimals, as uploaded from the speadsheet). However, in https://samples.oagr.org.au/sample/1/, for example, at the bottom of the page, most values for Carbon Dates have lots of decimals (e.g., 19.89999999999999857891), which seems to be a made up number as this amount of decimals was never in our uploaded data. screen shot 2016-04-05 at 2 43 18 pm

Li-ReDBox commented 8 years ago

In the model of c14, they have very high precision: 20 decimal places

jsoubrier commented 8 years ago

Does that mean the program 'makes up' decimals when they are absent for displaying on the samples page? Can we simply reduce that to 2 decimals for clarity? Thanks!

Li-ReDBox commented 8 years ago

I will have some investigation to see where the problem is. I am not sure if it is a display problem. Of course, if no high accuracy is required, I can convert them into another type.

jsoubrier commented 8 years ago

Thing is, I don't think we ever had this number of decimals to start with... Here is what has been uploaded to the C14 table (original data - sample 1 is the same example as above): screen shot 2016-04-07 at 09 58 49

The display on the C14 page of the database looks good and reflects the original data input: screen shot 2016-04-07 at 10 01 56

If we could display exactly the same on the sample page (without the 25 decimals) it would be perfect, otherwise, just fixing it at 2 decimals would do the trick for us :-)

Cheers!

Li-ReDBox commented 8 years ago

Follow up: index page of C14 uses a display conversion filter which hides when these decimal numbers are precision loose.

I applied this conversion on sample's detail page.

Please check if it has fixed the problem.

jsoubrier commented 8 years ago

Working great! Thanks Li