Static Image Generation Only Uses one Tile

[boldtrn]

I just tried to use the static tile generation. However, the resulting tiles seems to be only using one tile.

I can see that there is a warning in the log:

mlgl: {
  class: 'General',
  severity: 'WARNING',
  text: 'Provided camera options returned 4 tiles, only 11/1100/671=>11 is taken in Tile mode.'
}
GET /styles/my-style/static/13.389587,52.515359,12/500x500.png 200 162572 - 63.870 ms

The generated static map looks like this:

The same with the "old tileserver-gl" looks like this:

To me it seems that only one source tile is used, the warning message seem to hint at that as well. Interestingly some text is still used on the empty tiles? This seems to be related to the observations made here: https://github.com/maptiler/tileserver-gl/issues/542

[acalcutt]

I'm not to familiar with static images but I will check it out. For you second image, do you know what version of tileserver-gl is running there? The thread you links seems to suggest it relates to tile mode, which was added after tileserver 3.0.0 . Are you running 3.1.0+ in that second example?

[boldtrn]

Sorry for creating so much trouble :). The second image is done with maptiler/tileserver-gl:v3.1.0. I can check other versions if this would help you in debugging this case?

[acalcutt]

that version should be fine, I just wanted to make sure the version you are using was after tile mode was added. probably means there is something to find in maplibre-native

[acalcutt]

I can confirm the issue on my server https://tiles.wifidb.net/styles/WDB_OSM/static/13.389587,52.515359,12/500x500.png

[acalcutt]

looking at the maplibre-native render tests, its somewhat similar to this failed test

Its supposed to look like this, but it is trimming the map at the tile borders

[acalcutt]

Similar warnings too

# xvfb-run -a ./build/mbgl-render-test-runner --manifestPath metrics/macos-xcode11-release-style.json --filter "render-tests/map-mode/tile-avoid-edges"
[WARNING] {mbgl-render-tes}[ParseStyle]: The 'width' metadata field is ignored in tile map mode
[WARNING] {mbgl-render-tes}[ParseStyle]: The 'height' metadata field is ignored in tile map mode
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[INFO] {mbgl-render-tes}[General]: GPU Identifier: llvmpipe (LLVM 11.0.1, 256 bits)
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
[WARNING] {mbgl-render-tes}[General]: Provided camera options returned 4 tiles, only 13/2099/3045=>13 is taken in Tile mode.
* failed render-tests/map-mode/tile-avoid-edges
1 failed (100.0%)

[acalcutt]

I made a new custom maplibre-gl-native release that removes this commit https://github.com/maplibre/maplibre-gl-native/commit/9ceb619940901d06909f7d6d0fc4a4e64572d228 . it is @acalcutt/maplibre-gl-native 5.2.2

Then I made a new Tileserver-GL release that uses this package, v4.0.23. Can you try out this release and tell me how it works for you. it seems to fix static tiles for me.

[boldtrn]

Thank you very much, this fixes the static tile generation on my server as well. It would be great if we could get this merged updstream at gl-native as well, WDYT?

[acalcutt]

I'm trying to get it there, but upstream changes can be slow.

On the maplibre side it is usually hard to convince them the fix is to delete a block of code. obviously it works, but they asked me if i could make tileserver go into staic mode instead of tile mode when doing static images. however looking at the tileserver code that doesn't seem simple because it builds a pool of renderers when it loads, then uses them for various purposes later. unfortunately tile mode is needed for everything else but static tiles.

On the Tilserver-gl side i have started to add some PRs to get some of my changes there. However @kloklan wants to meet me first and discuss the changes. they want more gradual piecemeal PRs there and right now it is somewhat slow to get them approved. I'm supposed to meet with him next week, but I'm not sure whats going to come of that.

[acalcutt]

Also, i am trying not to use my realease of maplibre-gl-native is the maptiler version, so it really does need a fix upsteam.

[boldtrn]

Perfectly understandable, thanks for explaining. So far I am really happy that we have a working server 🎉

I would be happy to close this issue, or do you want to keep it open until we have an upstream solution?

[acalcutt]

I'd close this for now. I have my issue open upstream to try and get this officially fixed, so I think that is enough of a reference. I'll keep my maplibre-native until we figure out a better solution.

[boldtrn]

Ok perfect, let's close then :)