acangiani / django-tagging

Automatically exported from code.google.com/p/django-tagging
Other
1 stars 0 forks source link

django signal refactoring #146

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Since [8223] django signal refactoring tagging is broken with trunk, here
is a fix

--- tagging/fields.py   (revision 140)
+++ tagging/fields.py   (working copy)
@@ -3,7 +3,6 @@
 """
 from django.db.models import signals
 from django.db.models.fields import CharField
-from django.dispatch import dispatcher
 from django.utils.translation import ugettext_lazy as _

 from tagging import settings
@@ -30,7 +29,8 @@
         setattr(cls, self.name, self)

         # Save tags back to the database post-save
-        dispatcher.connect(self._save, signal=signals.post_save, sender=cls)
+        my_signal = signals.post_save 
+        my_signal.connect(self._save, sender=cls)

     def __get__(self, instance, owner=None):
         """
@@ -74,7 +74,7 @@
             value = value.lower()
         self._set_instance_tag_cache(instance, value)

-    def _save(self, signal, sender, instance):
+    def _save(self, signal, sender, instance, **kwargs):
         """
         Save tags back to the database
         """

Original issue reported on code.google.com by fane...@gmail.com on 11 Aug 2008 at 2:29

GoogleCodeExporter commented 9 years ago
Oups doublon of #144

Original comment by fane...@gmail.com on 11 Aug 2008 at 2:30

GoogleCodeExporter commented 9 years ago
Duplicate of #144

Original comment by doug.nap...@gmail.com on 11 Aug 2008 at 6:16