search

acasi-ctf / ctf

Capture the Flag Learning Platform
https://acasi-ctf.github.io/docs
Apache License 2.0
4 stars 2 forks source link

Fix terminal size not being correct unless first resized. #190

Closed kubeliv closed 2 years ago

kubeliv commented 2 years ago

This pull request fixes a bug where if a challenge environment is started, the backing terminal PTY will not have the correct rows and columns. This was fixed by sending a resize message upon the first message that was sent from the Termproxy layer. Fixes #189.

Testing

Manual testing was performed to ensure the correct behavior is exhibited.

Before and after

image

image

codecov[bot] commented 2 years ago

Codecov Report

Merging #190 (9bad0e2) into main (e4e6dc6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #190   +/-   ##
=========================================
  Coverage     80.25%   80.25%           
  Complexity       56       56           
=========================================
  Files            19       19           
  Lines           395      395           
  Branches         26       26           
=========================================
  Hits            317      317           
  Misses           60       60           
  Partials         18       18
Flag Coverage Δ
unittests 80.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4e6dc6...9bad0e2. Read the comment docs.