The gleep/update UI rotation speed

accassid / dice-gen

A three.js based dice generator react app.

17 stars 7 forks source link

The gleep/update UI rotation speed #88

Closed Earl-Brown closed 3 years ago

Earl-Brown commented 3 years ago

right-clicking in the preview area now brings up an options dialog with orbit speed sensitivity and a checkbox for whether or not to display the grid.

Changes made:

Added UIOptions type
Added UIOptionsPopup view
Moved ValueCheckbox and ValueSlider out to Controls folder parallel to App to make them available to UIOptionsPopup
Renamed "Controls" to "OrbitView" to make it's purpose more clear
Added sliderColumns and spinnerColumns properties to ValueSlider (it was not using all columns in the Options dialog)

Earl-Brown commented 3 years ago

I am sure there will be suggestions for formatting and code style - I welcome them, and will keep an eye out to make the changes as soon as possible!

Earl-Brown commented 3 years ago

Thanks for the feedback - I will work to make these changes.

Earl-Brown commented 3 years ago

I have revised the interface to honor suggestions:

changed menu to icon so it indicates what will happen when it is clicked (collapsed or expanded)
Added a "config" icon
bound the configuration dialog to the config button and changed where it appears

Earl-Brown commented 3 years ago

In my earlier comments, I forgot to mention that I'm leaving my original popup instead of using a modal, because I couldn't see a way to have a modal allow the user to interact with the preview; I like it better to have the users able to test the speed they've set before they close the window.

Earl-Brown commented 3 years ago

Thanks for all of the comments and suggestions!

I'll work to fix them. Be prepared to find more issues :)

And I'll fix them as soon as I can!

accassid commented 3 years ago

Looks good! Seems to be just one compilation warning. Fix that up and it should be good to go. Screenshot from 2021-03-08 18-08-57

accassid commented 3 years ago

Looks good! Seems to be just one compilation warning. Fix that up and it should be good to go.

Actually, nevermind, that must have been on dev when you forked it and it's fixed now. Never bad to rebase before a PR though.

Earl-Brown commented 3 years ago

Sweet, Thanks!

On March 8, 2021 6:14:56 PM MST, Andrew Cassidy notifications@github.com wrote:

Merged #88 into develop.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/accassid/dice-gen/pull/88#event-4424507764

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.