search

accel-sim / accel-sim-framework

This is the top-level repository for the Accel-Sim framework.
https://accel-sim.github.io
Other
290 stars 110 forks source link

Fix unneeded read in `trace_parser` #189

Open ammrat13 opened 1 year ago

ammrat13 commented 1 year ago

The parse_from_string method in trace_parser.cc currently reads in one delta for each active thread. However, tracer_tool.cu does not write the delta for the first thread since it will always be zero. This commit updates the behavior of trace_parser to match the intended trace format.

Even though this bug was present, it had no effect in the past since the base_delta_decompress function is correct.

William-An commented 1 year ago

@JRPan @tgrogers For the Jenkins test cases, do we only get traces with stride memory pattern? Looks like his original modification that removes the base_delta_compress call should either crash or generate invalid results for the simulator.