search

accel-sim / accel-sim-framework

This is the top-level repository for the Accel-Sim framework.
https://accel-sim.github.io
Other
289 stars 110 forks source link

Updating the GPGPU-Sim Build flow to make the version of GPGPU-sim you are using more explicit #214

Closed tgrogers closed 1 year ago

tgrogers commented 1 year ago

Now you can have GPGPU-Sim in many different places, and you aren't forced to sync/modify the setup_enviroment file. I also added a user prompt (that Jenkins short circuits) to allow users to select which repo/branch they want to use when they first run setup_envuronment. No submodules used here - still on the fence if we want to use them for GPGPU-Sim or not.

tgrogers commented 1 year ago

@cesar-avalos3, @JRPan - for ease of development, do you think we want to soft link gpgpu-sim into the subdirectory even if your repo is elsewhere? You would still have to set find/grep to traverse soft links - but it probably makes the code more traversable. What does VSCode do with softlinks?

JRPan commented 1 year ago

Generally VSCode treat soft links as folders. However I remember there were some feature not working very well. I'm pretty sure it was bugged. All standard feature in vscode should work. We should be fine

LAhmos commented 1 year ago

Are we switching to submodule?

tgrogers commented 1 year ago

@LAhmos - Not now - it looks like it submodule is going to cause its own set of issues and this is at least better than what we had.

@JRPan - can we approve this? @cesar-avalos3 - provided you are both good with this :)

cesar-avalos3 commented 1 year ago

I agree, seems like more trouble than its worth