Simulator crashes if the las kernel is a memcpy

accel-sim / accel-sim-framework

This is the top-level repository for the Accel-Sim framework.

https://accel-sim.github.io

Other

294 stars 113 forks source link

Simulator crashes if the las kernel is a memcpy #286

Open rodhuega opened 6 months ago

rodhuega commented 6 months ago

The simulator is crashing with assert(k) in main.cc

The reason is due to finding as a last kernel a MemcpyHtoD,0x00007f2483b08a00,4 instead of a kernel-X.traceg. This behavior has been observed in parboil-bfs with an Ampere trace.

Hopefully, this can be fixed by replacing an if by: if ( (finished_kernel_uid || m_gpgpu_sim->cycle_insn_cta_max_hit() || !m_gpgpu_sim->active()) && !kernels_info.empty() )

However, I don't know if you are thinking in a different solution.

JRPan commented 6 months ago

I'm more curious about why the last kernel is MemcpyHtoD. I'm worrying that maybe there was a kernel launch after that, but the tracer crashed and was unable to catch it. MemcpyHtoD to GPU without consuming the data sounds like a weird use case to me.

Thanks