search

accellera-official / systemc

SystemC Reference Implementation
https://systemc.org/overview/systemc/
Apache License 2.0
451 stars 145 forks source link

Add C++ 17 to supported values of CMAKE_CXX_STANDARD #16

Closed felixonmars closed 2 years ago

felixonmars commented 2 years ago

As of GCC 11, g++ defaults to use C++ 17. I have tried to pass -DCMAKE_CXX_STANDARD=17 and verified that SC builds fine and all tests pass.

markfoodyburton commented 2 years ago

Hi, thanks for your contribution, would you mind adding a signed-of-by line, with your affiliation.

For your contribution to be applicable for consideration by the Accellera working groups, you need to sign-off the Accellera Developer's Certificate of Origin as described in the CONTRIBUTING file.

Thanks

felixonmars commented 2 years ago

Updated with --signoff :)

markfoodyburton commented 2 years ago

Thanks!

markfoodyburton commented 2 years ago

The LWG is aware of bigger issues with the CMake build systems and will be working on that, but this can be merged for now, thank you for your patch.