search

accellera-official / systemc

SystemC Reference Implementation
https://systemc.org/overview/systemc/
Apache License 2.0
445 stars 141 forks source link

Fix macOS PowerPC #55

Closed barracuda156 closed 3 months ago

barracuda156 commented 1 year ago

Fixes: https://github.com/accellera-official/systemc/issues/54

barracuda156 commented 1 year ago

@lmailletcontoz Could you please take a look at this, and another two PRs below? I have 100% tests passing now on macOS PowerPC.

maehne commented 10 months ago

@pah: Could you have a look on this PR and the associated issue?

lmailletcontoz commented 6 months ago

PowerPC is only supported using POSIX threads in SystemC 3.0.0

barracuda156 commented 6 months ago

@lmailletcontoz @maehne You still have ppc64 broken though in 3.0.0: there is no define for it in CMakeLists.

maehne commented 6 months ago

@lmailletcontoz: Please reopen so that maybe @pah can have a second look.

barracuda156 commented 6 months ago

@maehne I have rebased to master and dropped QuickThreads addition as unneeded now.

lmailletcontoz commented 3 months ago

configuration no longer supported

barracuda156 commented 3 months ago

@lmailletcontoz We are not taking about QuickThreads here anymore.

Macros here have ppc but lack ppc64: https://github.com/accellera-official/systemc/blob/bec101067d808f93bf215031dff6fa9ab7035995/CMakeLists.txt#L335-L336

Macros here have neither: https://github.com/accellera-official/systemc/blob/bec101067d808f93bf215031dff6fa9ab7035995/CMakeLists.txt#L339-L427

barracuda156 commented 3 months ago

@maehne I think as long as it builds fine de facto, there is no reason to prevent that merely by not having a case in arch/platform detection. That can’t possibly hurt anyone.

pah commented 3 months ago

This is merely a cosmetic issue. The library may (or may not) still build on such unsupported configurations. If you want a different target architecture string than macosunknown in such an unsupported scenario, you can set the environment variable SYSTEMC_TARGET_ARCH during the cmake configuration step.