accentor / api

API for the Accentor music server
Other
10 stars 1 forks source link

Handle images that can't be resized better #118

Open robbevp opened 4 years ago

robbevp commented 4 years ago

If the user uploads an image that cannot be resized, they don't get an error, but the image is also not returned in the serializer.

chvp commented 3 years ago

Do you have an example of a (valid) image that can't be resized?

robbevp commented 3 years ago

I don't have the image that caused this error anymore. So I don't know if it was valid (though it must have displayed on the website where I got it from).

chvp commented 3 years ago

I know there were a few PDFs at some point, but that doesn't make any sense to return in the image field. Unless we find a valid image that is not shown this way, I don't think we should return (a link to) it in the JSON.