accentor / api

API for the Accentor music server
Other
9 stars 1 forks source link

Allow users to rate albums #2

Open chvp opened 4 years ago

robbevp commented 3 years ago

Been thinking about how we would structure this.

Airsonic allows both favourites and a rating, which feels redundant to me. For albums ratings make more sense than a favourite. But for artists and tracks a favourite makes more sense than a rating. Do we

chvp commented 3 years ago

I'm not sure I agree that ratings make more sense than a favourite for albums. What would be the use for a rating system that wouldn't be covered by favs? Do we expect users to rank albums by rating? Do we want to calculate averages over users? Do we want dynamic collages that include albums above a certain rating? To me, the answer to all those questions is no.

I wouldn't make this too generic. We don't expect other models to pop up where favouriting or rating would make sense and a little duplication to keep things simple feels like the better option to me.

robbevp commented 3 years ago

A rating has the benefit of allowing more nuance. With a favs, an album either is a favourite or the value isn't set (it would be pretty unusual to distinguish between false and nil for this kind of thing). So this leaves no way to dislike something, or give it a mediocre opinion.

That doesn't mean that I necessarily want ratings over favs. Giving something 2/5 instead of 3/5 can feel very abitrary, but there is an inherit benefit to ratings over favs.

I wouldn't make this too generic. We don't expect other models to pop up where favouriting or rating would make sense and a little duplication to keep things simple feels like the better option to me.

But you agree with doing albums, artists and tracks, right?

chvp commented 3 years ago

I get the benefit of allowing ratings, I just don't see a usecase within accentor for allowing ratings over favs.

I agree with albums, artists and tracks, yes.

robbevp commented 3 years ago

The fact that a user might want to give a more nuanced rating rather then a favourite would be a usecase in itself, no?

chvp commented 3 years ago

I don't thinks so? Accentor is a music player at heart, I don't see how being able to give a nuanced rating helps that core idea.