search

accenturelabs / midaas-expanded-api

Expanded midaas-api
https://accenturelabs.github.io/midaas-expanded-api/
2 stars 1 forks source link

might want to consider using values that don't need to be encoded #4

Open adamsfallen opened 8 years ago

adamsfallen commented 8 years ago

e.g. 65+, african american, etc.

mike-wendt commented 8 years ago

I would like to change these as well because they are non-standard but they match midaas-api exactly

We can change them but we would break compatibility, I'm not sure how important that is @kkraus14 @adamsfallen

adamsfallen commented 8 years ago

fwiw it's nbd to me, as our app currently supports url encoding, but just fyi maybe midaas-api should eventually switch over too.

mike-wendt commented 8 years ago

@datametrician thoughts on this? We can switch to ID based like we have education, industry, occupation already

Time to do this would be about 20 mins fwiw

datametrician commented 8 years ago

I'm impartial. I like this way more, but at the same time, then we are deviating from midaas. Let's do it, and if they want to reuse this they can switch it later.

kkraus14 commented 8 years ago

@mike-wendt do you need me to change anything in the data generation or is this handled in the api backend?

mike-wendt commented 8 years ago

@kkraus14 this can be handled within the api, I'll make the change tomorrow

mike-wendt commented 8 years ago

@datametrician @kkraus14 my only hesitation with changing this is this causes more changes to the midaas website code with the bar charts that I was working on as an example to explore our data... unless you want me to hold off on that