search

accenturelabs / midaas-expanded-api

Expanded midaas-api
https://accenturelabs.github.io/midaas-expanded-api/
2 stars 1 forks source link

API response now has weird nesting ("overall:") #6

Closed adamsfallen closed 8 years ago

adamsfallen commented 8 years ago

responses used to look like: {"5%":"300","10%":"3000","20%":"8100","30%":"13500","40%":"19400","50%":"25000","60%":"31700","70%":"40000","80%":"50000","90%":"70000","95%":"92000","99%":"165000"}

now look like: {"overall":{"5%":300,"10%":3000,"20%":8100,"30%":13500,"40%":19400,"50%":25000,"60%":31700,"70%":40000,"80%":50000,"90%":70000,"95%":92000,"99%":165000}}

Is this a bug or by design?

mike-wendt commented 8 years ago

By design and new docs are coming but got pulled into a meeting. Will publish asap

-Mike Wendt

On Jul 14, 2016, at 11:53, Adam Bonnifield notifications@github.com wrote:

responses used to look like: {"5%":"300","10%":"3000","20%":"8100","30%":"13500","40%":"19400","50%":"25000","60%":"31700","70%":"40000","80%":"50000","90%":"70000","95%":"92000","99%":"165000"}

now look like: {"overall":{"5%":300,"10%":3000,"20%":8100,"30%":13500,"40%":19400,"50%":25000,"60%":31700,"70%":40000,"80%":50000,"90%":70000,"95%":92000,"99%":165000}}

Is this a bug or by design?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

mike-wendt commented 8 years ago

This is to match what midaas-api actually returns and for what the chart expects https://midaas.commerce.gov/developers/#widgets-bar-chart