search

access-company / antikythera

Elixir framework to build your own in-house PaaS
Apache License 2.0
219 stars 19 forks source link

Revert "[253873] Update hex libraries (#209)" #210

Closed Double-oxygeN closed 1 year ago

Double-oxygeN commented 1 year ago

https://acsmine.tok.access-company.com/redmine/issues/255215#note-11

This reverts commit 6db73defe975369ec44897d1705befc3e5952020 (#209). This is necessary to add URL empty path detection before updating Hackney.

Double-oxygeN commented 1 year ago

It's hard to understand this description. This description focuses on what you're doing now. You should write why this revert is needed.

I think you should describe about the unintended API change due to the hackney update. Then, you'll add logging in another PR and update hackney with the API change in another PR.

I apologize for the lack of explanation.

The reason why this revert must be to do is because Hackney, which is updated by #209, has a problem about handling URLs with empty path while sending HTTP requests. Hackney 0.16.0 or later sends illegal HTTP requests for URLs with empty path, such as https://example.com?q=query. Therefore, the function for detecting such URLs (#211) is needed for debugging running gears before updating the library.

Anyway, thank you all for reviewing this PR.