Theme ESLint and Prettier updates. - Githubissues

accessdigital / wilson

A Drupal installation profile produced by Access. New installations should use https://github.com/accessdigital/drupal-template

https://www.weareaccess.co.uk

4 stars 1 forks source link

Theme ESLint and Prettier updates. #21

Closed rob-howells closed 2 years ago

rob-howells commented 2 years ago

Background / motivation

Improve code quality and consistency by widening the scope of which files are detected by ESLint and Prettier
Fix issue where theme fonts are not loading (default / fallback font is displayed)

Approach

Changed scope of ESLint and Prettier NPM scripts to look at all JS in the theme (excluding anything in ESLint and Prettier ignore files)
Updated SCSS and JS file name to improve consistency
Updated inclusion of font SCSS so font @imports are first

Notes

Many of the changes in this PR were originally included in https://github.com/accessdigital/wilson/pull/20, however this work is currently on hold (and so are now included here to avoid holding things up)