Closed AccessPaul closed 2 years ago
The only thing I'm a little wary of is that there are a lot of
<div>
tags in templates that don't have any classes etc associated with them, which makes me wonder whether they're semantically necessary. I realise they're wrapping content and possibly grouping fields, so I haven't commented/blocked this PR, I just wonder whether a slightly different structure could work.
Yeah I wondered about this too. Because there's a lot of use of CSS grid for layout, we do need block-level tags around certain fields to form cells of the grid. Quite often there's no need to add styling to these so that's why they ended up as <div>
tags with no classes. We could possibly use different HTML5 tags (I'm never fully confident when to use <section>
tags for instance) or give them arbitrary CSS classes so they look more owned. As you say, needs some thought but not blocking right now.
Done as one PR because there were inter-related changes. Sorry for the size but this crosses off a few things on the Wilson wishlist.
Hero
Grid utilities
--two-of-three-cols
.w-2/3-cols
.grid-cols-2-pref-l
(2 columns where the left column is wider than the right)Tabs
Default content
Tailwind config