Closed jobara closed 11 months ago
@greatislander in fixing the failing test I realized that I may have removed some functionality, but I'm also not sure how that part was supposed to work or if it was actually functional on the site. I wonder if you could weigh in. Basically I removed the language bits from the controllers. It looks like you could use that to pass in a query parameter to have an individual or organization public page rendered in an alternative language if one was provided. However, I don't see how a user could have specified that query parameter. Am I understanding this correctly? Have I missed something? Is this still needed?
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
ccaa90c
) 97.63% compared to head (bb50619
) 97.60%. Report is 1 commits behind head on dev.:exclamation: Current head bb50619 differs from pull request most recent head af2731e. Consider uploading reports for the commit af2731e to get more accurate results
Files | Patch % | Lines |
---|---|---|
app/helpers.php | 80.95% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@greatislander in fixing the failing test I realized that I may have removed some functionality, but I'm also not sure how that part was supposed to work or if it was actually functional on the site. I wonder if you could weigh in. Basically I removed the language bits from the controllers. It looks like you could use that to pass in a query parameter to have an individual or organization public page rendered in an alternative language if one was provided. However, I don't see how a user could have specified that query parameter. Am I understanding this correctly? Have I missed something? Is this still needed?
I spoke with @greatislander about this. The $language
set from the query parameter is to allow those pages to be shown in different languages, if they've been added for them by the user/org. This for example would allow an organization to localize their public page in many languages even though the site only supports a couple. Will need to bring that functionality back. The original work for this was done under #505.
While the written language supports from HasMultimodalTranslations isn't required any more, the rough in for the ASL/LSQ upload options is still requested to remain, in case we implement those features in the future (See: #455).
While reviewing this, @greatislander found two other bugs ( #2029, #2028 ). If possible these should be addressed alongside this one.
Resolves #2014 Resolves #2026 Resolves #2028 Resolves #2029
get_written_language_for_signed_language
toto_written_language
localized_route_for_locale
helperroute_name
helpermissingKeyCallback
to fallback lsq to frPrerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.BEGIN_COMMIT_OVERRIDE fix: model lsq translations don't fallback to fr (resolves #2014, #2026) (#2027)
fix: rendering of language changer links (resolves #2028, #2029) (#2027) fix: response time in other languages not saved (#2027) fix: can't add other engagement languages (#2027) fix: not displaying content in translation (#2027) END_COMMIT_OVERRIDE