Closed jobara closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
59004ee
) 97.65% compared to head (77f62a7
) 97.65%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @jobara, seems like removing the lines would resolve the issue notified by Flare; however, are the logics in removed lines not needed?
Not anymore. I added a link in the description to the commit it was removed from Livewire. It had been a workaround.
Resolves #2045
Removes use of
numberOfPaginatorsRendered
as this was removed from Livewire 3.See: https://github.com/livewire/livewire/commit/a81b6fd59e5ec961c5b154539e8ca91effde6a94
Prerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.BEGIN_COMMIT_OVERRIDE fix: pagination throws error (resolves #2045) #2046 END_COMMIT_OVERRIDE