accessibility-exchange / platform

The Accessibility Exchange platform.
https://github.com/orgs/accessibility-exchange/projects/2/views/8
BSD 3-Clause "New" or "Revised" License
4 stars 10 forks source link

fix: pagination throws error (resolves #2045) #2046

Closed jobara closed 9 months ago

jobara commented 9 months ago

Resolves #2045

Removes use of numberOfPaginatorsRendered as this was removed from Livewire 3.

See: https://github.com/livewire/livewire/commit/a81b6fd59e5ec961c5b154539e8ca91effde6a94

Prerequisites

If this PR changes PHP code or dependencies:

If this PR changes CSS or JavaScript code or dependencies:

BEGIN_COMMIT_OVERRIDE fix: pagination throws error (resolves #2045) #2046 END_COMMIT_OVERRIDE

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (59004ee) 97.65% compared to head (77f62a7) 97.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2046 +/- ## ========================================= Coverage 97.65% 97.65% Complexity 2055 2055 ========================================= Files 314 314 Lines 8991 8991 ========================================= Hits 8780 8780 Misses 211 211 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jobara commented 9 months ago

Thanks @jobara, seems like removing the lines would resolve the issue notified by Flare; however, are the logics in removed lines not needed?

Not anymore. I added a link in the description to the commit it was removed from Livewire. It had been a workaround.