Sectors and Areas of impact are not being properly localized

accessibility-exchange / platform

The Accessibility Exchange platform.

https://github.com/orgs/accessibility-exchange/projects/2/views/8

BSD 3-Clause "New" or "Revised" License

4 stars 10 forks source link

Sectors and Areas of impact are not being properly localized #2077

Closed jobara closed 9 months ago

jobara commented 9 months ago

Prerequisites

[X] I've searched for existing issues

Describe the bug

When creating and viewing projects the sectors and areas of impact show up in English, even when the site is in French.

Expected behavior

The text should be displayed in French when the site is in French.

Screenshots

jobara commented 9 months ago

It seems this is because the Sectors and Impacts are modelled. There are seders to create the models, but the translations were likely not available when the seeder was run initially in the staging and productions sites. This is why the issue isn't reproducible on the dev site and locally, because the translations are now available, meaning their databases are created with the correct translations.

jobara commented 9 months ago

One question is if these should actually be in the database at all, or if they should be moved to an Enum.

jobara commented 9 months ago

In talking to @greatislander, he suggested keeping them as models so that it would be easier to maintain the database integrity if there are bigger changes in the future. If we go this route, we should add these models to the filament admin.

jobara commented 9 months ago

I've manually updated the Staging and Production databases to have the French translations for the Sectors and Impacts. These models should be added to filament; which will be done as part of #2080