fix: accessing settings during database reset causes error (resolves #2106)

accessibility-exchange / platform

The Accessibility Exchange platform.

https://github.com/orgs/accessibility-exchange/projects/2/views/8

BSD 3-Clause "New" or "Revised" License

4 stars 10 forks source link

fix: accessing settings during database reset causes error (resolves #2106) #2134

Closed jobara closed 6 months ago

jobara commented 6 months ago

Resolves #2106

Updates php artisan app:refresh-dev to pre-render the 503 error page
Updates the settings helper function to return the default if the settings database table isn't present
Sets defaults when checking the settings for the phone number and address

Prerequisites

If this PR changes PHP code or dependencies:

[x] I've run composer format and fixed any code formatting issues.
[x] I've run composer analyze and addressed any static analysis issues.
[x] I've run php artisan test and ensured that all tests pass.
[x] I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

[ ] I've run npm run lint and fixed any linting issues.
[ ] I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (449dff5) 97.94% compared to head (ec2751d) 97.93%. Report is 1 commits behind head on dev.

Files	Patch %	Lines
app/helpers.php	50.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #2134 +/- ## ============================================ - Coverage 97.94% 97.93% -0.01% Complexity 2145 2145 ============================================ Files 333 333 Lines 9789 9791 +2 ============================================ + Hits 9588 9589 +1 - Misses 201 202 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marvinroman commented 6 months ago

I ran the same test locally on a container built with the jobara:GH-2106.

I was no longer able to duplicate any of the errors when running php artisan app:refresh-dev

jobara commented 6 months ago

As a note, I wasn't able to test the case from the settings function where the table doesn't exist. I could drop the table, but it was causing other tests to break, so I've left it off. Hence the drop in coverage.