Closed jobara closed 6 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
449dff5
) 97.94% compared to head (ec2751d
) 97.93%. Report is 1 commits behind head on dev.
Files | Patch % | Lines |
---|---|---|
app/helpers.php | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I ran the same test locally on a container built with the jobara:GH-2106.
I was no longer able to duplicate any of the errors when running php artisan app:refresh-dev
As a note, I wasn't able to test the case from the settings
function where the table doesn't exist. I could drop the table, but it was causing other tests to break, so I've left it off. Hence the drop in coverage.
Resolves #2106
php artisan app:refresh-dev
to pre-render the 503 error pagesettings
helper function to return the default if the settings database table isn't presentPrerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.