search

accessifix / nvda-for-vs-code

NVDA add-on for Microsoft Visual Studio Code improving InteliSense, code completion support, and other accessibility features.
GNU General Public License v3.0
19 stars 10 forks source link

NVDA Reads First Character of Next Line after Accepting Autocomplete Suggestion #13

Open LordLuceus opened 3 years ago

LordLuceus commented 3 years ago

After updating to the latest version of this addon, NVDA now reads out the first character on the next line down whenever I accept an autocomplete suggestion. For example, let's say I have this function:

const greet = () => {
  console.log("Hello there!");
};

For the sake of the example, let's say I want to change the console.log to console.error for some reason. I go to that line, delete log and type e. Autocomplete pops up, I press enter to accept, and NVDA says "right brace", where previously it would have said nothing.

I'm on NVDA 2020.4, VSCode 1.55.1, and version 20.2.0 of this addon.

zersiax commented 3 years ago

Confirmed. I'd like there to be some sort of output when a suggestion is accepted, but yeah ...the first letter of the next line wasn't exactly what I had in mind :)

pawelurbanski commented 3 years ago

I confirmed this behavior. I am using insider version 1.59 since it will soon be the next stable version. The current stable version as of the date of writing: 1.58 does suffer from this bug. I spotted the possible error. I will fix it as soon as possible to update the add-on and make it compatible with NVDA 2021.1. I would like to note that some changes in Electron itself introduced some negative sideeffects in how text in the editor textarea field is handled. I will file an issue in VS Code and Electron repositories. I field it in the NVDA repository, but never got any response. Nobody responded to the same request on the NVDA development list. Since NVDA does not have any means for debugging besides logging, it is at times rather difficult to uncover what is causing the problem at hand. I will be doing my best, for I care first and foremost about convenience and ergonomics.