Fix permissions and basetag

accetto / ubuntu-vnc-xfce-g3

Headless Ubuntu/Xfce containers with VNC/noVNC (G3v6).

MIT License

214 stars 62 forks source link

Fix permissions and basetag #58

Open pm-gmr opened 8 months ago

pm-gmr commented 8 months ago

Adds missing executable permissions for scripts and allows a custom BASETAG when using a different BASEIMAGE (e.g. ros:noetic).

accetto commented 8 months ago

Hello @pm-gmr , I want just to confirm, that I've noticed your PR. I appreciate it very much. However, I'll come to it later, because I'm pretty busy now. Regards, accetto

pm-gmr commented 8 months ago

Sure. No problem. I was trying to use a different base image (osrf/ros:noetic-desktop-full) and encountered this issue. Thought I'll contribute a fix. Merge/review as per your convenience.