accodeing / fortnox-api

Gem that abstracts Fortnox's F3 API
GNU Lesser General Public License v3.0
9 stars 8 forks source link

Spec refactoring #137

Open ehannes opened 6 years ago

ehannes commented 6 years ago

Our specs are not the most pretty ones out there. They need some refactoring.

One goal with this gem is to make it as easy as possible to add new resources. Repositories, Models and Mappers does not include any logic at all. These classes does not need any testing. If we instead focus on testing Repository::Base, Model::Base and Mapper::Base then all we need to test for each new resource is the integration with Fortnox, that it really works. We should therefore:

d-Pixie commented 6 years ago

We should put this on hold for a bit. #149 will change the spec landscape quite a bit and it might be better if we did the refactoring of the test suite after the split.

d-Pixie commented 6 years ago

Updated original comment to reflect the split of the specs between this gem and the new base gem.