search

accodeing / fortnox-api

Gem that abstracts Fortnox's F3 API
GNU Lesser General Public License v3.0
9 stars 8 forks source link

Removes using_test_classes #203

Closed ehannes closed 2 years ago

ehannes commented 2 years ago

Fixes #200

Instead of using the advanced using_test_classes, we can just stub the constants. You could use let statements for some of the cases as well, but when you want to do slightly more, like wrapping the class in a module, stubbing constants is much easier. I think it's best to keep things consistent here, so I decided to make all test classes into stubbed constants. It's very easy to read as well.

https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LeakyConstantDeclaration

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 831148ec and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.4% (0.0% change).

View more on Code Climate.