search

accodeing / fortnox-api

Gem that abstracts Fortnox's F3 API
GNU Lesser General Public License v3.0
9 stars 8 forks source link

Rubocop update #210

Closed ehannes closed 2 years ago

ehannes commented 2 years ago

Fixes #208

Rubocop was too old to support Ruby 2.6 that we are now requiring. This lead to a crash in Codeclimate when it tried to run Rubocop.

This PR includes a lot of auto corrections from Rubocop. I made a few manual changes to fix some violations also. All testa are passing :smiley:

ehannes commented 2 years ago

Hmm, I wonder why codeclimate is still failing... This PR should fix that problem...

ehannes commented 2 years ago

I guess codeclimate runs both against development and the new branch since it displays the difference that this PR introduces. I guess we need to merge this PR first before codeclimate will start working again.

d-Pixie commented 2 years ago

I guess codeclimate runs both against development and the new branch since it displays the difference that this PR introduces. I guess we need to merge this PR first before codeclimate will start working again.

/usr/local/bundle/gems/rubocop-0.52.1/lib/rubocop/config.rb:510:in `check_target_ruby': Unknown Ruby version 2.6 found in `TargetRubyVersion` parameter (in .rubocop.yml). (RuboCop::ValidationError)
Supported versions: 2.1, 2.2, 2.3, 2.4, 2.5

I'm guessing because ...

ehannes commented 2 years ago

Yeah, I know about that error message, but this PR was intended to fix that problem. But I guess codeclimate runs both on development and rubocop-update, and development is of course still broken. Let's merge this PR to find out :D