Closed maokomioko closed 1 year ago
codeclimate[bot]
commented
1 year ago Code Climate has analyzed commit 515e55bc and detected 5 issues on this pull request.
Here's the issue category breakdown:
| Category | Count |
|---|---|
| Duplication | 2 |
| Complexity | 1 |
| Style | 2 |
The test coverage on the diff in this pull request is 96.2% (50% is the threshold).
This pull request will bring the total coverage in the repository to 98.6% (0.2% change).
View more on Code Climate.
ehannes
commented
1 year ago Hi @maokomioko! Thanks for your PR. We'll take a look at it and get back to you.
ehannes
commented
1 year ago @maokomioko again, thanks for your pull request, really appreciate it! 😄 We have a few questions regarding the code though. This pull request mixes several changes: bumps of dry-dependencies, Rubocop upgrades and fixes, dev gem upgrades and some other fixes. Also, there's only one commit, so there's no way for us to track the changes you have made. We would like to split this into several pull requests to be able to review one change at a time. Now, we don't know which of the changes are due to Rubocop upgrades or which are due to fixes and dry-dependency upgrades. We would be happy to get in contact with you to discuss how we can make use of your code. Please contact us at info@accodeing.com to discuss how we can proceed 😃
Also, it happens to be so that we have an ongoing project were we, today, took the decision to use this gem. For us, this means that we need updated dry-dependencies as soon as possible. If you contact us before we have time to start the work ourselves, we would be more than happy to use your code. If not, we might need to start with the upgrade ourselves.
ehannes
commented
1 year ago Closed in favor of #227
This PR bumps all dry-* dependencies and adjusts some of the rubocop issues. Fingers crossed for passing specs :)