Fix broken dependencies

accodeing / fortnox-api

Gem that abstracts Fortnox's F3 API

GNU Lesser General Public License v3.0

9 stars 8 forks source link

Fix broken dependencies #226

Closed ehannes closed 1 year ago

ehannes commented 1 year ago

Fixes #209
Adds missing dependencies which broke the gem
Drops support for Ruby 2.6 (dry-configurable 0.15 requires 2.7)

Thanks to @maokomioko, I was able to use some of your code to do these changes. It's not our intention to ignore your PR but as we said, we need to fix this gem now and your PR is mixing a lot of changes which makes it really hard to reuse. Please contact us so that we can have a talk about it 😄

I will continue upgrading the dependencies in upcoming pull requests the coming days.

ehannes commented 1 year ago

Build for Ruby 3 is still broken, which is expected...

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 8a310f34 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.0% change).

View more on Code Climate.

ehannes commented 1 year ago

Closed in favor of #228