Dry libs upgrade rubocop fixes new cops

accodeing / fortnox-api

Gem that abstracts Fortnox's F3 API

GNU Lesser General Public License v3.0

9 stars 8 forks source link

Dry libs upgrade rubocop fixes new cops #232

Closed ehannes closed 1 year ago

ehannes commented 1 year ago

More Rubocop fixes. Adds a lot of new Rubocop cops.

ehannes commented 1 year ago

@d-Pixie what do you think about the code duplication that codeclimate is complaining about? Looks like something we should not bother about... It's just similar test setup...

d-Pixie commented 1 year ago

I say ignore it. I agree with you that extracting that wouldn't make the code better, but it would make it harder to read so ... Easy choice 🙂

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 164ee977 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	4

The test coverage on the diff in this pull request is 81.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.4% (0.0% change).

View more on Code Climate.